[ 
https://issues.apache.org/jira/browse/CB-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131355#comment-15131355
 ] 

ASF GitHub Bot commented on CB-10332:
-------------------------------------

Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/471#discussion_r51805298
  
    --- Diff: www/docs/en/dev/guide/platforms/android/tools.md ---
    @@ -19,206 +19,218 @@ license: >
     
     title: Android Shell Tool Guide
     ---
    -
     # Android Shell Tool Guide
     
    -This guide shows how to use Cordova's set of platform-centered shell
    -tools to develop Android apps. This development path, discussed in the
    -[Overview](../../overview/index.html), may offer you a greater range of 
development options than
    -the cross-platform CLI tool described in [The Command-Line 
Interface](../../cli/index.html).
    -For example, you need to use shell tools when deploying a custom
    -Cordova WebView alongside native components.  Before using either
    -development path, you must first configure the Android SDK environment
    -as described in the [Android Platform Guide](index.html).
    +## Building with Gradle
     
    -To enable shell tools for Android, download Cordova from
    -[cordova.apache.org](http://cordova.apache.org). The download contains
    -separate archives for each platform. Expand each you wish to target,
    -`android` in this case. The relevant tools are typically available in
    -the top-level `bin` directory, otherwise consult the __README__ file
    -for more detailed directions.
    +As of **cordova-android@4.0.0**, Cordova for Android projects are built 
using
    +[Gradle](http://www.gradle.org/). For instructions on building with Ant, 
refer
    +to older versions of the documentation.
     
    -These tools allow you to create, build, and run Android apps.  For
    -information on the additional command-line interface that enables
    -plugin features across all platforms, see Using Plugman to Manage
    -Plugins. See Application Plugins for details on how to develop
    -plugins.
    +### Gradle Properties
     
    -## Create a Project
    +It is possible to configure the Gradle build by setting the values of 
certain
    +[Gradle 
properties](https://docs.gradle.org/current/userguide/build_environment.html)
    +that Cordova exposes. The following properties are available to be set:
     
    -Run the `create` command, specifying the existing path to the project,
    -the reverse-domain-style package identifier, and the app's display
    -name.  Here is the syntax for both Mac/Linux and Windows:
    +  * **cdvBuildMultipleApks** (default: false)
    --- End diff --
    
    Can we have these in a table? Makes it more readable. 


> Improve Android Guide
> ---------------------
>
>                 Key: CB-10332
>                 URL: https://issues.apache.org/jira/browse/CB-10332
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: Docs
>            Reporter: Raghav
>            Assignee: Richard B Knoll
>              Labels: Docs-6.x
>
> We did a document scrub and found the following issues. Please feel free to 
> correct other things as well.
> - Android Platform Guide
> -- Install Cordova Shell tools is out of date
> -- Environment variable instructions for Windows are out of date
> -- Emulator section can just point to 
> http://developer.android.com/tools/devices/emulator.html
> -- Lots of duplicated content for create/build/deploy from CLI page
> -- Page keeps switching between CLI and platform-centric workflow
> - Android Shell Tool Guide
> -- Second paragraph is out of date
> -- Create/build/run/logging/clean should be clear that this is the 
> platform-centric workflow. Also duplicated in Android Platform guide
> -- Platform-centric workflow should probably just get its own explicit page
> -- Signing an app doesn't actually say how to sign an app. Gives arguments 
> for some mystery command
> --- Does this belong in our docs? We might just mention it and point to 
> Google's app signing instructions
> - Android WebViews
> -- Needs investigation if this is still supported.
> --- Step 1 is wrong (should be getting cordova-android by cloning or from npm)
> --- Step 3 needs to have instructions for adding jars to gradle
> --- Step 5 is out of date. CordovaActivity does not implement 
> CordovaInterface... Think they should be extending/modifying CordovaActivity. 
> Needs investigation
> --- Step 6 does not appear to be camera plugin specific
> --- Step 7 example is useless, it needs to be fleshed out
> - Android plugins
> -- Should be moved to plugin developer docs
> -- Need a reference for the classes that plugins have access to
> --- CordovaWebView, CallbackContext, CordovaPlugin, etc.
> --- Most already have javadoc
> -- Android Integration should be renamed and link to the Android classes it's 
> talking about
> -- Debugging Android plugins is out of date (mentions Eclipse and jars) and 
> should probably be fleshed out a bit
> - Android Configuration
> -- Should be a reference
> - Upgrading Android
> -- Ends at 4.0.0 (current is 4.1.1, soon to be 5.0.0)
> -- Needs to be reorganized in some way
> --- The instructions seem to be pretty much the same for versions 1.6.0 +
> -- Goes back to the phonegap days! Should probably only include Cordova 
> versions (1.5.0 +)
> -- Upgrade to 1.8.0 from 1.7.0 repeated twice
> -- Upgrade to 1.8.0 from 1.8.0 is a typo
> General guidelines:
> - While giving examples, keep them short. Do not repeat for all 
> plugins/platforms.
> - Remove all references to cordova plugin registry.
> - Remove Tizen references. The platform is deprecated 
> (http://markmail.org/message/hryg6sjswecpgndu)
> - Keep information up to date for the platforms, CLI and plugins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to