[ https://issues.apache.org/jira/browse/CB-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145243#comment-15145243 ]
ASF GitHub Bot commented on CB-10592: ------------------------------------- Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/386#discussion_r52794591 --- Diff: cordova-lib/src/cordova/util.js --- @@ -297,7 +297,7 @@ function ensurePlatformOptionsCompatible (platformOptions) { }).map(function (arg) { return opts[arg] === true ? '--' + arg : - '--' + arg + '="' + opts[arg].toString() + '"'; + '--' + arg + '=' + opts[arg].toString(); --- End diff -- Alright, fair enough. Do you think we can deprecate this usage in the future though? It's a really awkward (and also insecure) API. > cordova additionally quotes platform specific arguments when used > programmatically > ---------------------------------------------------------------------------------- > > Key: CB-10592 > URL: https://issues.apache.org/jira/browse/CB-10592 > Project: Apache Cordova > Issue Type: Bug > Affects Versions: 6.0.0 > Environment: Cordova@6.0.0, OS X or *nix machine > Reporter: Vladimir Kotikov > Assignee: Vladimir Kotikov > > Some platform-specific arguments (such as {{--gradleArg}}) is additionally > quoted, when options passed to {{cordova.raw}} API using old format. Though > this is not a problem on Windows, because the command processor on handles > such arguments correctly, on OS X this leads to unexpected failures. > For example running > {noformat} > cordova.raw.build({ > platforms: [android], > options: ["--gradleArg=--no-daemon"] > }) > {noformat} > causes gradle build failure with following message {{Task '"--no-daemon"' not > found in root project 'android'.}} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org