[
https://issues.apache.org/jira/browse/CB-10668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157775#comment-15157775
]
ASF GitHub Bot commented on CB-10668:
-------------------------------------
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-ios/pull/196
CB-10668 Moved node_modules to root
* updated package.json to include dependencies and bundledDependencies
* updated create.js to copy root node_modules instead of bin/node_modules
* removed bin/node_modules directory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #196
----
commit c1dcdf9de166a18a179f70f398efb60e82d2ee99
Author: Steve Gill <[email protected]>
Date: 2016-02-22T21:47:04Z
CB-10668 updated create.js to grab node_modules from root, updated
package.json
commit cc7f19112aa39ed946243193439659ae7bb1d833
Author: Steve Gill <[email protected]>
Date: 2016-02-22T21:47:23Z
CB-10668 removed bin/node_modules
commit a7f059c01f14e99f67a01c7a37df96b913f9a15f
Author: Steve Gill <[email protected]>
Date: 2016-02-22T21:48:25Z
CB-10668 checked in node_modules
----
> move node_modules to package.json and update create script to copy from root
> ----------------------------------------------------------------------------
>
> Key: CB-10668
> URL: https://issues.apache.org/jira/browse/CB-10668
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS, OSX
> Reporter: Steve Gill
> Assignee: Steve Gill
>
> Right now, node_modules lives in cordova-ios/bin/node_modules. That means we
> aren't managing those deps anywhere (not in package.json). I propose moving
> these into the root package.json and adding them as bundledDependenceis. Then
> update the create script to copy the root/node_modules directory instead of
> root/bin/node_modules.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
