[ 
https://issues.apache.org/jira/browse/CB-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162774#comment-15162774
 ] 

ASF GitHub Bot commented on CB-10636:
-------------------------------------

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53918932
  
    --- Diff: tests/tests.js ---
    @@ -3040,20 +3045,19 @@ exports.defineAutoTests = function () {
                         expect(entries[0].toNativeURL).toBeDefined();
                         expect(typeof entries[0].toNativeURL).toBe('function');
                         var nativeURL = entries[0].toNativeURL();
    -                    var indexOfRoot = isWindows ? nativeURL.indexOf(":") :
    -                                      isChrome ? 
'filesystem:file://'.length : // Chrome uses own prefix for all filesystem urls
    -                                      7; //default value - length of 
'file://' string
                         expect(typeof nativeURL).toBe("string");
                         expect(nativeURL.substring(0, 
pathExpect.length)).toEqual(pathExpect);
                         expect(nativeURL.substring(nativeURL.length - 
fileName.length)).toEqual(fileName);
                         // cleanup
    +                    // TODO: debug this
    --- End diff --
    
    Thanks, this is addressed below, just forgot to rm the comment.


> Add JSHint for plugins
> ----------------------
>
>                 Key: CB-10636
>                 URL: https://issues.apache.org/jira/browse/CB-10636
>             Project: Apache Cordova
>          Issue Type: Task
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to