[ 
https://issues.apache.org/jira/browse/CB-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176703#comment-15176703
 ] 

ASF GitHub Bot commented on CB-10178:
-------------------------------------

Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/528#discussion_r54811063
  
    --- Diff: www/docs/en/dev/guide/overview/index.md ---
    @@ -129,27 +125,20 @@ task, they each offer advantages:
       this workflow if you need to modify the project within the SDK. This 
       workflow relies on a set of lower-level shell scripts that are tailored 
for 
       each supported platform, and a separate Plugman utility that allows you 
to 
    -  apply plugins.  While you can use this workflow to build cross-platform
    +  apply plugins. While you can use this workflow to build cross-platform
       apps, it is generally more difficult because the lack of a
       higher-level tool means separate build cycles and plugin
    -  modifications for each platform. Still, this workflow allows you
    -  greater access to development options provided by each SDK, and is
    -  essential for complex hybrid apps.
    +  modifications for each platform. 
     
     When first starting out, it may be easiest to use the cross-platform
    -workflow to create an app, as described in [The Command-Line 
Interface](../cli/index.html).
    +workflow to create an app, as described in [Create your first app 
tutorial](../cli/index.html).
    --- End diff --
    
    Here too.


> Unclear windows phone documentation for icons and splash screens
> ----------------------------------------------------------------
>
>                 Key: CB-10178
>                 URL: https://issues.apache.org/jira/browse/CB-10178
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Docs
>    Affects Versions: 5.4.0
>         Environment: Phonegap CLI, building to Windows platform. Testing on 
> physical windows phone device and on windows phone emulator. 
>            Reporter: Rupert McKay
>            Assignee: Nikhil Khandelwal
>            Priority: Minor
>              Labels: Docs-6.x, triaged, windows
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/images.md
> In the section 'Configuring Icons in the CLI' the windows sections neglect to 
> mention the affect adding a .scale-100 or .scale-240 extension can have to 
> how source images get mapped to destination images. 
> The examples provided will all default to mapping onto .scale-100. 
> Recommend adding examples like the following:
> {code:xml}
>     <platform name="windows">
>         <icon src="www/res/windows/SplashScreenPhone.scale-240.png" 
> width="1152" height="1920" />
>         <icon src="www/res/windows/Square30x30Logo.scale-100.png" width="30" 
> height="30" />
>         <icon src="www/res/windows/Square44x44Logo.scale-100.png" width="44" 
> height="44" />
>         <icon src="www/res/windows/Square44x44Logo.scale-240.png" width="106" 
> height="106" />
>         <icon src="www/res/windows/Square70x70Logo.scale-100.png" width="70" 
> height="70" />
>         <icon src="www/res/windows/Square71x71Logo.scale-100.png" width="71" 
> height="71" />
>         <icon src="www/res/windows/Square71x71Logo.scale-240.png" width="170" 
> height="170" />
>         <icon src="www/res/windows/Square150x150Logo.scale-100.png" 
> width="150" height="150" />
>         <icon src="www/res/windows/Square150x150Logo.scale-240.png" 
> width="360" height="360" />
>         <icon src="www/res/windows/Square310x310Logo.scale-100.png" 
> width="310" height="310" />
>         <icon src="www/res/windows/StoreLogo.scale-100.png" width="50" 
> height="50" />
>         <icon src="www/res/windows/StoreLogo.scale-240.png" width="120" 
> height="120" />
>         <icon src="www/res/windows/Wide310x150Logo.scale-240.png" width="744" 
> height="360" />
>         <icon src="www/res/windows/Wide310x150Logo.scale-100.png" width="310" 
> height="150" />
>         <splash src="www/res/windows/SplashScreen.scale-100.png" width="620" 
> height="300" />
>     </platform>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to