[ 
https://issues.apache.org/jira/browse/CB-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179605#comment-15179605
 ] 

ASF GitHub Bot commented on CB-10784:
-------------------------------------

Github user jcesarmobile commented on the pull request:

    
https://github.com/apache/cordova-plugin-contacts/pull/107#issuecomment-192202738
  
    LGMT
    
    I think it's not necessary in this case, but maybe you can use a weakSelf, 
as the current code already uses a lot of this:
    `CDVContacts* __weak weakSelf = self; // play it safe to avoid retain 
cycles`
    



> Unable to use Cordova Plugins that use a native view directly on pickContacts 
> callback.
> ---------------------------------------------------------------------------------------
>
>                 Key: CB-10784
>                 URL: https://issues.apache.org/jira/browse/CB-10784
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>    Affects Versions: Master
>         Environment: iOS
>            Reporter: Cory Thompson
>            Priority: Minor
>              Labels: ios
>
> I attempted to open a native dialog directly after a using pickContacts and 
> receive the following error on iOS.
> navigator.contacts.pickContact(onContactItemPickedSuccess, 
> onContactItemPickedError);
> function onContactItemPickedSuccess(contact) {
>      navigator.notification.confirm(…);
> }
> Warning: Attempt to present <UIAlertController: 0x14a83600> on 
> <CDVContactsPicker: 0x151e7400> whose view is not in the window hierarchy!
> A workaround is wrap the confirmation code using a JavaScript setTimeout for 
> 1000ms.
> I’ve dug into the Objective C code and what I suspect is happening is that 
> the successCallback is called before the animation for closing the 
> CDVContactsPicker has finished.
> I’ve tested moving the callback after the close animation and my issue is 
> resolved. I will include a pull request in the comments.
> The only potential problem I see with this is the original author may have 
> decided to return before animation close so that a user could update the HTML 
> behind the contactPicker therefore appearing to load much faster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to