[
https://issues.apache.org/jira/browse/CB-10865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197666#comment-15197666
]
ASF GitHub Bot commented on CB-10865:
-------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/195#discussion_r56371109
--- Diff: tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m ---
@@ -304,24 +303,28 @@ - (void) testImageScaleNoCropForSize {
// test 800x600
- targetSize = CGSizeMake(800, 600);
+ targetSize = CGSizeMake(600, 800);
targetImage = [sourceImagePortrait
imageByScalingNotCroppingForSize:targetSize];
XCTAssertEqual(targetImage.size.width, targetSize.width);
XCTAssertEqual(targetImage.size.height, targetSize.height);
+ targetSize = CGSizeMake(800, 600);
+
targetImage = [sourceImageLandscape
imageByScalingNotCroppingForSize:targetSize];
XCTAssertEqual(targetImage.size.width, targetSize.width);
XCTAssertEqual(targetImage.size.height, targetSize.height);
// test 1024x768
- targetSize = CGSizeMake(1024, 768);
+ targetSize = CGSizeMake(768, 1024);
targetImage = [sourceImagePortrait
imageByScalingNotCroppingForSize:targetSize];
XCTAssertEqual(targetImage.size.width, targetSize.width);
XCTAssertEqual(targetImage.size.height, targetSize.height);
+ targetSize = CGSizeMake(1024, 768);
+
--- End diff --
It might make life easier to put these guys in a loop.
> Run ios native tests on Travis
> ------------------------------
>
> Key: CB-10865
> URL: https://issues.apache.org/jira/browse/CB-10865
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Camera
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
