[ https://issues.apache.org/jira/browse/CB-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15216806#comment-15216806 ]
ASF GitHub Bot commented on CB-10927: ------------------------------------- Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57797472 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -305,17 +306,25 @@ describe('windows project handler', function () { var frameworks = copyArray(valid_frameworks); it('should write to correct project files when conditions are specified', function () { - var xpath = 'ProjectReference[@Include="' + winJoin(dummyplugin, 'src', 'windows', 'dummy1.vcxproj') + '"][@Condition="\'$(Platform)\'==\'x64\'"]'; + var curDir; + var xpath; + + curDir = __dirname; + process.chdir(path.join(curDir, '..', 'fixtures', 'testProj')); + + xpath = 'ProjectReference[@Include="' + winJoin('..', '..', 'plugins', 'org.test.plugins.dummyplugin', 'src', 'windows', 'dummy1.vcxproj') + '"][@Condition="\'$(Platform)\'==\'x64\'"]'; validateInstalledProjects('framework', frameworks[6], xpath, ['all']); - xpath = 'ProjectReference[@Include="' + winJoin(dummyplugin, 'src', 'windows', 'dummy2.vcxproj') + '"]'; + xpath = 'ProjectReference[@Include="' + winJoin('..', '..', 'plugins', 'org.test.plugins.dummyplugin', 'src', 'windows', 'dummy2.vcxproj') + '"]'; validateInstalledProjects('framework', frameworks[7], xpath, ['windows8']); - xpath = 'ProjectReference[@Include="' + winJoin(dummyplugin, 'src', 'windows', 'dummy3.vcxproj') + '"]'; + xpath = 'ProjectReference[@Include="' + winJoin('..', '..', 'plugins', 'org.test.plugins.dummyplugin', 'src', 'windows', 'dummy3.vcxproj') + '"]'; validateInstalledProjects('framework', frameworks[8], xpath, ['windows', 'windows8', 'windows10']); - xpath = 'ProjectReference[@Include="' + winJoin(dummyplugin, 'src', 'windows', 'dummy4.vcxproj') + '"][@Condition="\'$(Platform)\'==\'x86\'"]'; --- End diff -- Don't we need this condition anymore? > Framework references in plugin.xml file prevent Windows Universal projects > from being used on other machines > ------------------------------------------------------------------------------------------------------------ > > Key: CB-10927 > URL: https://issues.apache.org/jira/browse/CB-10927 > Project: Apache Cordova > Issue Type: Bug > Components: Windows > Reporter: James Dubee > Labels: triaged > > For Windows Universal, a framework reference in plugin.xml files results in a > hardcoded path being written to CordovaApp.sln, and CordovaApp.Phone.jsproj. > This hardcoded path is specific to the user's machine in which the plugin was > installed on. This prevents moving a project from one machine to another > without manually editing CordovaApp.sln, and CordovaApp.Phone.jsproj. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org