[ https://issues.apache.org/jira/browse/CB-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222618#comment-15222618 ]
ASF GitHub Bot commented on CB-8115: ------------------------------------ Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/113#discussion_r58285822 --- Diff: www/convertUtils.js --- @@ -0,0 +1,61 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * +*/ + +var utils = require('cordova/utils'); + +module.exports = { + /** + * Converts primitives into Complex Object + * Currently only used for Date fields + */ + toCordova: function (contact) { --- End diff -- Are we anticipating adding more conversions to these functions like the comments indicate? Also, small nitpick: it would be nice to rename these to something a little more descriptive, like `toCordovaFormat` and `toNativeFormat`. `toCordova` reads a little strangely to me. > incorrect birthday saved to phonebook using Contacts Plugin > ----------------------------------------------------------- > > Key: CB-8115 > URL: https://issues.apache.org/jira/browse/CB-8115 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Affects Versions: 4.0.0 > Environment: Android and IOS > Reporter: Kiran Jain > Assignee: Sergey Shakhnazarov > Priority: Minor > Labels: Android, IOS, birthday, reproduced, triaged > > We are facing an issue while trying to add birthday to Contact while using > Cordova for android while adding a new contact to the phonebook > following is part of the code > contact = navigator.contacts.create({ > "displayName": displayname > }); > // store contact name > var contactName = new ContactName(); > contactName.familyName = lastname; > contactName.givenName = firstname > contact.name = contactName; > contact.birthday = new Date("16 May 1984"); > // save the contact > contact.save(); > With above code, when data is viewed in android phone, the birthday is save > as 29-12-6731 instead of expected 16-May-1984 > we have tried all possible combinations of date entry viz: 16-May-1984 ; > 16/May/1984 ; 16/5/1984 ; new date(1984,05,16) > but all in vain the results are the same. > also need to know how to save anniversary date > when using this plugin for IOS, the date saved is 15-May-1984 (1 day less > than expected). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org