[
https://issues.apache.org/jira/browse/CB-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238974#comment-15238974
]
ASF GitHub Bot commented on CB-11074:
-------------------------------------
GitHub user akofman opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7
Fixes CB-11074: WKWebView configuration is not considered
I updated the configuration before the WKWebView initialisation in order to
consider it.
It implies that the updateWithInfo method doesn't update it anymore. I'm
not sure it is really a problem but I'd prefer @shazron to confirm.
Thanks for the reviews !
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akofman/cordova-plugin-wkwebview-engine master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 18219a0fe66208cc3ff1a794908510194cf86668
Author: Alexis Kofman <alexis.kof...@gmail.com>
Date: 2016-04-13T09:46:45Z
Fixes CB-11074: WKWebView configuration is not considered
----
> WKWebView configuration is not considered
> -----------------------------------------
>
> Key: CB-11074
> URL: https://issues.apache.org/jira/browse/CB-11074
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin WKWebViewEngine
> Environment: ios
> Reporter: Alexis Kofman
> Priority: Critical
>
> Regarding the code of WKWebView.h, WKWebViewConfiguration seems to be a
> readonly property.
> {code}
> @property (nonatomic, readonly, copy) WKWebViewConfiguration *configuration;
> {code}
> But in this plugin, we are trying to update the WKWebView configuration after
> initialising it and it looks like all this part is not considered :
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L146-L150
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
