[ 
https://issues.apache.org/jira/browse/CB-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248509#comment-15248509
 ] 

ASF GitHub Bot commented on CB-10475:
-------------------------------------

Github user sarangan12 commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/94#discussion_r60300760
  
    --- Diff: lib/medicPermissions.js ---
    @@ -0,0 +1,63 @@
    +#!/usr/bin/env node
    +
    +/* jshint node: true */
    +var path    = require('path');
    +var fs              = require('fs');
    +var shelljs  = require("shelljs");
    +//var logger  = require('./utils').logger;
    +var util     = require("./util");
    +
    +function MedicPermissions(appName, simulatorsFolder, tccDbPath) {
    +   this.appName = appName;
    +   this.simulatorsFolder = simulatorsFolder;
    +   this.tccDbPath = tccDbPath;
    +}
    +
    +MedicPermissions.prototype.updatePermissions = function(serviceList) {
    --- End diff --
    
    Though this will work, you could modify the logic as
    
    1. Check for existence of TCC.db file. If not copy an empty file. 
    2. Do the insert command. 
    
    This will simplify the logic. Refer my latest paramedic PR for details. 
Also, you could reuse the same logic for finding simId instead of copying it 
for all simulators. 
    
    Also, minor code changes for running the command is required. Refer latest 
paramedic PR for details


> iOS contacts permission modal causes contacts tests to fail
> -----------------------------------------------------------
>
>                 Key: CB-10475
>                 URL: https://issues.apache.org/jira/browse/CB-10475
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: Medic
>         Environment: OSX
>            Reporter: Richard B Knoll
>            Assignee: Sarangan Rajamanickam
>            Priority: Minor
>              Labels: found-by-ci, ios, triaged
>
> cordova-ios CI returned test results and all of the contacts tests failed:
> https://ci.apache.org/builders/cordova-ios/builds/1605/steps/getting-test-results/logs/stdio
> Turns out a modal had appeared asking for permission to access contacts and 
> was never dismissed. After I clicked okay in the modal, everything was green 
> on the next build:
> https://ci.apache.org/builders/cordova-ios/builds/1606
> We either need a way to grant the permissions or we should exclude these 
> tests from the CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to