[ https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258548#comment-15258548 ]
ASF GitHub Bot commented on CB-11136: ------------------------------------- Github user ephemer commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-214827853 Thank you, my pleasure. I have thought about this a bit longer.. The main issue is that recent Cordova changes, namely introducing WKWebView, have broken this plugin for a significant use case, namely OAuth. The changes suggested here put the functionality back to how it was before the internal changes broke it. I'd prefer a different solution but until we have that I think it's important that the plugin does what it's supposed to. Making these changes depend on an option like `modal: false` is a bit like providing the option `worksAsItIsSupposedTo: true`. If anything we could provide an option `useStrictlyModalBrowser: true` or similar to opt-in to the new WKWebView behaviour. @jcesarsh what do you think, looking at this in that light? > InAppBrowser fails to close with WKWebView OAuth > ------------------------------------------------- > > Key: CB-11136 > URL: https://issues.apache.org/jira/browse/CB-11136 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin InAppBrowser, Plugin WKWebViewEngine > Affects Versions: 4.1.0 > Environment: iOS 8+ with WKWebView > Reporter: Geordie Jay > Original Estimate: 3h > Remaining Estimate: 3h > > Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for > OAuth (e.g. Facebook or Google login) fails to close as it should. > The reason is that the entire WKWebView thread seems to pause when another > view controller is presented. This can be confirmed by inspecting the > WKWebView session in Safari, running `window.open('http://something.com')` > and then trying to enter another command into that Safari console. > I made a hacky but working version of this that animated in the > InAppBrowser's view manually, rather than 'presenting' the ViewController in > the traditional iOS style. In that instance the WKWebView thread continues as > normal and receives the confirmation to close the other InAppBrowser when the > OAuth process is complete. > Maybe there is a better way around this, but at the moment this is a big > usability fail for all WKWebView users. > What do you all think, is the 'not-actually-presenting' way of presenting the > InAppBrowser acceptable? Would be happy to make a pull request along these > lines if it is. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org