[
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264921#comment-15264921
]
ASF GitHub Bot commented on CB-10653:
-------------------------------------
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-215903575
## [Current coverage][cc-pull] is **73.49%**
> Merging [#173][cc-pull] into [master][cc-base-branch] will increase
coverage by **-26.51%**
```diff
@@ master #173 diff @@
==========================================
Files 14 14
Lines 3202 1852 -1350
Methods 339 340 +1
Messages 0 0
Branches 451 379 -72
==========================================
- Hits 3202 1361 -1841
- Misses 0 491 +491
Partials 0 0
```
1. 14 files (not in diff) in `template/cordova/lib` were modified.
[more](https://codecov.io/gh/apache/cordova-windows/commit/7d02a1ac6bbeccf8bcc3783bd93086c8eab1ceaa/changes?src=pr#74656D706C6174652F636F72646F76612F6C6962)
- Misses `+491`
- Hits `-1841`
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by
[bbd8de7...7d02a1a][cc-compare]
[cc-base-branch]:
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]:
https://codecov.io/gh/apache/cordova-windows/compare/bbd8de71dbfa8c3b03f5e67c60a63f6818ca42eb...7d02a1ac6bbeccf8bcc3783bd93086c8eab1ceaa
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/173?src=pr
> Universal Windows Platform -- activationContext is incomplete
> -------------------------------------------------------------
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Environment: Windows 10, Windows 10 Phone
> Reporter: Adam Fourney
> Assignee: Raghav Katyal
> Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's
> onactivated event, and record the details in the platform.activationContext
> instance.
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation
> events. As an example, if an app is activated by a Cortana voice command, the
> details are missed. See here for more details:
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
> var args = e.detail.arguments;
> var actType = e.detail.type;
> platform.activationContext = { type: actType, args: args };
> cordova.fireDocumentEvent('activated', platform.activationContext,
> true);
> };
> To be:
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; //
> Backwards compatibility
> cordova.fireDocumentEvent('activated',
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
