[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269090#comment-15269090
]
ASF GitHub Bot commented on CB-11194:
-------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61917144
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require('underscore');
var Q = require('q');
-var shell = require('shelljs');
+var which = require('shelljs/src/which');
--- End diff --
this eliminates multiple copies of `shelljs` - since every module gets it's
own version. There are two versions of cordova-common loaded and hence two
shelljs modules.
If we do update the version of shelljs and this breaks - it would be very
obvious to fix. I have a PR in the works to submit to shelljs to delay load on
their side.
> Improve cordova load time
> -------------------------
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
> Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
