[ https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271298#comment-15271298 ]
ASF GitHub Bot commented on CB-9858: ------------------------------------ Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62100822 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + 'License'); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + */ + +var Q = require('q'); +var shell = require('shelljs'); +var superspawn = require('cordova-common').superspawn; +var events = require('cordova-common').events; +var depls = require('dependency-ls'); +var path = require('path'); +var fs = require('fs'); +var CordovaError = require('cordova-common').CordovaError; +var isUrl = require('is-url'); + +/* + * A function that npm installs a module from npm or a git url + * + * @param {String} target the packageID or git url + * @param {String} dest destination of where to install the module + * @param {Object} opts [opts={save:true}] options to pass to fetch module + * + * @return {String||Promise} Returns string of the absolute path to the installed module. + * + */ +module.exports = function(target, dest, opts) { + var fetchArgs = ['install']; + opts = opts || {}; + var tree1; + + //check if npm is installed + isNpmInstalled(); --- End diff -- Your right. I originally has it connected to the promise change but removed it during a refactor. I'll fix this! > Implement Cordova Fetch Proposal > -------------------------------- > > Key: CB-9858 > URL: https://issues.apache.org/jira/browse/CB-9858 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib > Reporter: Steve Gill > Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > https://github.com/cordova/cordova-discuss/pull/33 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org