[
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347111#comment-15347111
]
ASF GitHub Bot commented on CB-9371:
------------------------------------
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/260
@cjpearson unfortunately this patch can't be applied since the code has
changed. Can you re-work it based on the master code? Also, the code you are
trying to patch is the default fallback if a platform does not conform to the
Platform API (older platforms). For newer platforms that do, like
cordova-ios@4.x, they have their own Platform API implementations -- so the
corresponding code would exist here:
https://github.com/apache/cordova-ios/blob/08e00b68efbf2bfee21866f0bedd9c01ee8255e5/bin/templates/scripts/cordova/lib/prepare.js#L252-L275
> Prepare deletes orientation preferences
> ---------------------------------------
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 5.1.1
> Reporter: Connor Pearson
>
> If a user does not have a orientation preference defined in config.xml then
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation
> preferences, otherwise it should respect the values that are already there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
