[
https://issues.apache.org/jira/browse/CB-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380052#comment-15380052
]
ASF GitHub Bot commented on CB-3360:
------------------------------------
GitHub user AlexandreAbreu opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/174
CB-3360 Fix Oxide version & support _system target for ubuntu
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Ubuntu
### What does this PR do?
Fixes open() and add support for _system target option.
### What testing has been done on this change?
Tested that no regression occurred and support for supported target options.
### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to secret...@apache.org.
- [ X] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cordova-ubuntu/cordova-plugin-inappbrowser
fix-open
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit 9eeac01613882422ddddb5300a66eb3b17002244
Author: Alexandre Abreu <alexandre.ab...@canonical.com>
Date: 2016-07-15T20:19:35Z
Fix Oxide version & support _system target
----
> Set custom InAppBrowser user-agent
> ----------------------------------
>
> Key: CB-3360
> URL: https://issues.apache.org/jira/browse/CB-3360
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin InAppBrowser
> Affects Versions: 2.7.0
> Environment: iOS, Android, WP8, BlackBerry
> Reporter: Kevin Simpson
> Priority: Minor
> Labels: Cordova, InAppBrowser, android
>
> Currently you can set a custom user-agent for the main Cordova webview by
> overriding the init method for the DroidGap class. However, when opening a
> page in the InAppBrowser, that webview will still contain the default
> user-agent.
> There are two solutions that I have thought of to this:
> 1. Set the user-agent of the InAppBrowser webview to whatever the user-agent
> in the Cordova webview is set to. (This is what I am currently doing, as it
> was a one line change, but it requires rebuilding Cordova manually)
> 2. Have some sort of configuration option to set the user-agent for the
> InAppBrowser. This would allow a different user-agent from the main webview,
> but is also a more involved change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
