[
https://issues.apache.org/jira/browse/CB-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400326#comment-15400326
]
ASF GitHub Bot commented on CB-11645:
-------------------------------------
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/473
The only other consideration I can think of off the top of my head is that
the edit-config stuff also made changes to the android.json (and other
equivalent platform files) for edit-config support. They aren't breaking
changes as far as I know because I don't think the information that is saved
for the old config-file tag was altered (@ktop to confirm).
I believe the `PluginInfo` object is the only thing used in the platform
API that has changed. It might be worth someone else taking a look at the APIs
that changed and where they get used, though.
To avoid subtle breaks like this in the future, we should probably better
delineate what objects are part of the platform API and what are not. The
`PluginInfo` object gets used all over and it isn't immediately obvious that
altering it could cause effects like this (especially when using it in other
files in the same repo).
> [email protected] doesn't install plugins on <= [email protected]
> -----------------------------------------------------------------
>
> Key: CB-11645
> URL: https://issues.apache.org/jira/browse/CB-11645
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaCommon
> Reporter: Steve Gill
>
> Trying to add [email protected] or master using [email protected] will give
> the following error when installing the whitelist plugin
> `Failed to install 'cordova-plugin-whitelist':TypeError:
> pluginInfo.getEditConfigs is not a function
> at PlatformMunger.add_plugin_changes
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:134:42)
> at
> /Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:126:25
> at _fulfilled
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:834:54)
> at self.promiseDispatch.done
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:863:30)
> at Promise.promise.promiseDispatch
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:796:13)
> at
> /Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:857:14
> at runSingle
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:137:13)
> at flush
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:125:13)
> at _combinedTickCallback (internal/process/next_tick.js:67:7)
> at process._tickCallback (internal/process/next_tick.js:98:9)
> Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You
> might need to try adding it again. Error: TypeError:
> pluginInfo.getEditConfigs is not a function```
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
