[
https://issues.apache.org/jira/browse/CB-11478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403907#comment-15403907
]
ASF GitHub Bot commented on CB-11478:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/190#discussion_r73147848
--- Diff: template/cordova/lib/run.js ---
@@ -39,7 +39,7 @@ module.exports.run = function (options) {
// parse arg
var args = nopt({
- 'archs': String,
+ 'archs': [String],
--- End diff --
This just aligns `--archs` interpretation with `build` module (see
[build.js#L156](https://github.com/apache/cordova-windows/blob/43b101a6cbd8392d61e51dca01f25296ae84c89b/template/cordova/lib/build.js#L156)).
Also the logic below
([L65](https://github.com/apache/cordova-windows/pull/190/files#diff-31dc29ac3df976968b00e031ea8cde82R65))
translates `archs: String -> archs: String[]` so this change effectively won't
change existing behavior of 'run' command
> Windows run vs build archs parsing inconsistency
> ------------------------------------------------
>
> Key: CB-11478
> URL: https://issues.apache.org/jira/browse/CB-11478
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 4.4.2
> Reporter: Sergey Shakhnazarov
> Assignee: Vladimir Kotikov
> Labels: found-by-ci, reproduced, triaged, windows
> Fix For: 4.4.3
>
>
> {{cordova build windows -- --arch=x86}}
> {{cordova build windows --arch=x86}}
> Both of this commands work properly but there is an inconsistency with
> cordova run:
> {{cordova run windows -- --arch=x86}} // this works OK
> {{cordova run windows --arch=x86}} // this uses anycpu pkg
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
