[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418157#comment-15418157
 ] 

ASF GitHub Bot commented on CB-9825:
------------------------------------

Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/234
  
    Recapping our chat:
    
    5 unit test failures:
    ```
    Failures:
    
      1) installPodSync throws cordova error when no pod name provided
       Message:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.writeFileSync (fs.js:1327:33)
      at .<anonymous> 
(/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:33:11)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    
    
      2) installPodSync writes to the Podfile via fs.writeFileSync
       Message:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.writeFileSync (fs.js:1327:33)
      at createPodfile 
(/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:29:8)
      at Object.addToPodfileSync 
(/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:124:9)
      at .<anonymous> 
(/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:43:12)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    
    
      3) installPodSync writes to the Podfile via fs.writeFileSync
       Message:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.writeFileSync (fs.js:1327:33)
      at .<anonymous> 
(/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:33:11)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    
    
      4) uninstallPodSync removes pod from Podfile
       Message:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.readFileSync (fs.js:502:33)
      at editPodfileSync 
(/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:33:30)
      at Object.removeFromPodfileSync 
(/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:140:25)
      at .<anonymous> 
(/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:58:12)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    
    
      5) uninstallPodSync removes pod from Podfile
       Message:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.writeFileSync (fs.js:1327:33)
      at .<anonymous> 
(/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:54:8)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    ```
    
    1. `tests/spec/unit/fixtures/testProj/platforms/ios/` does not exist in the 
repo. Create a `.gitignore` so you can add the empty repo. This will make all 
tests pass.
    2. Remove the un-needed `fs.openSync(pathToPodfile, 'w');` in podMod.js
    3. the `tear down` is not working
         a. to have the proper sequence, you need to change `it('tests', 
function () {` to `describe('tests', function () {`
         b. teardown would be better if you used fs module 
`fs.unlinkSync(fixturePodfile);`
    
    The pods.json tests appear to be in the cordova-lib end to end tests, so 
it's not covered here.



> Support third-party package managers like Cocoapods and Nuget
> -------------------------------------------------------------
>
>                 Key: CB-9825
>                 URL: https://issues.apache.org/jira/browse/CB-9825
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CordovaLib
>            Reporter: Shazron Abdullah
>            Assignee: Julia Geist
>              Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to