[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439994#comment-15439994 ]
ASF GitHub Bot commented on CB-11776: ------------------------------------- GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/486 CB-11776 check edit-config target exists Missing a case in the conflict checking for edit-config. If the target doesn't exist in <platform>.json, and cannot resolve to an existing target, then no conflict should be found. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ktop/cordova-lib ecerror Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/486.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #486 ---- commit a7e6634217e187434d560ac2d32bf352662b3a25 Author: ktop <ktop...@gmail.com> Date: 2016-08-26T21:59:46Z CB-11776 check edit-config target exists ---- > Can't add two plugins with different edit-config targets > -------------------------------------------------------- > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: CordovaCommon > Affects Versions: 1.4.0 > Reporter: Karen Tran > Assignee: Karen Tran > Labels: edit-config > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org