[
https://issues.apache.org/jira/browse/CB-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464219#comment-15464219
]
ASF GitHub Bot commented on CB-11790:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/253
CB-11790 - Check that Cocoapods is installed by checking `pod install`
return code, show help text
Re-factored code to be modular - Podfile and PodsJson are abstractions for
the files themselves, and include unit-tests.
The addPlugin/removePlugin code in Api.js uses the two files above now,
resulting in cleaner and more maintainable code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-11790
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #253
----
commit 1673350afd24d919658c66c1b779fd7395558d87
Author: Shazron Abdullah <shaz...@apache.org>
Date: 2016-09-02T01:08:18Z
CB-11790 - Check that Cocoapods is installed by checking `pod install`
return code, show help text
Re-factored code to be modular - Podfile and PodsJson are abstractions for
the files themselves, and include unit-tests.
The addPlugin/removePlugin code in Api.js uses the two files above now,
resulting in cleaner and more maintainable code.
----
> Check that Cocoapods is installed by checking `pod install` return code,
> show help text
> ----------------------------------------------------------------------------------------
>
> Key: CB-11790
> URL: https://issues.apache.org/jira/browse/CB-11790
> Project: Apache Cordova
> Issue Type: Sub-task
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: iOS
> Reporter: Shazron Abdullah
>
> Line:
> https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59
> If it is not installed, we must error out and warn the user what to do.
> Currently, it just silently fails (pod install is called, but its error code
> is not checked).
> We need to decide what to do with the user experience issue if pod install is
> first run -- this triggers a Cocoapods repo clone, which at the time I write
> this is 475MB. The time to download this repo is non-trivial, and the size of
> the repo increases linearly each day. We should add a notice to the output
> that it might take a long time.
> Additionally, we could report the size of the Cocoapods repo by using the
> Github API like this Chrome Extension:
> https://github.com/harshjv/github-repo-size
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
