[
https://issues.apache.org/jira/browse/CB-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464557#comment-15464557
]
ASF GitHub Bot commented on CB-11661:
-------------------------------------
GitHub user jacquesdev opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/236
CB-11661: (ios) Add mandatory iOS 10 privacy description
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Ensures the plugin enables users to select photos from the photoalbum in
iOS10.
### What testing has been done on this change?
It was a bug in my app before, and after this change, I am now able to
successfully add photos to the photoalbum
### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
Add support for photoalbum description
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/OLIOEX/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #236
----
commit 2fa78680af444e837ced3b6374c5f3dc6acef53b
Author: Jacques de Villiers <jacques...@gmail.com>
Date: 2016-09-05T08:38:16Z
CB-11661: (ios) Add mandatory iOS 10 privacy description
Add support for photoalbum description
----
> Camera plugin crashes on iOS 10
> -------------------------------
>
> Key: CB-11661
> URL: https://issues.apache.org/jira/browse/CB-11661
> Project: Apache Cordova
> Issue Type: Sub-task
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Plugin Camera
> Affects Versions: 3.5.0
> Environment: iOS 10
> Reporter: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided
> a way to show the user why a certain permission is required. In iOS 10 this
> becomes mandatory, so any app not specifying the key will crash at runtime
> when a permissions is requested.
> This plugin requests the Camera permission, so at the very least we need to
> add NSCameraUsageDescription and NSPhotoLibraryUsageDescription to the
> `plist`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
