[ https://issues.apache.org/jira/browse/CB-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469214#comment-15469214 ]
ASF GitHub Bot commented on CB-1187: ------------------------------------ GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/116 CB-1187: (iOS) Fix unused recording settings ### Platforms affected iOS ### What does this PR do? easy fix: audioSettings object wasn't being passed in when starting a recording. ### What testing has been done on this change? run automated tests, run in custom app. All works as expected. build in xcode. Cleared up 2 warnings for an unused variable and null argument passed to recorder. ### Checklist - [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-media master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #116 ---- commit 642aef774aa60a34b29d451f684ffc67bf732700 Author: ghenry22 <ghenr...@gmail.com> Date: 2016-09-07T01:37:59Z CB-1187: (iOS) Fix unused recording settings ---- > Move the Objective-C unit-tests out of CordovaLib.xcodeproj, into its own > .xcodeproj > ------------------------------------------------------------------------------------ > > Key: CB-1187 > URL: https://issues.apache.org/jira/browse/CB-1187 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: iOS > Affects Versions: 2.0.0 > Reporter: Shazron Abdullah > Assignee: Andrew Grieve > Fix For: 2.1.0 > > > Right now CordovaLib.xcodeproj has two targets related to unit tests: > CordovaLibTests and CordovaLibApp. Move them to a .xcodeproj file but still > in the CordovaLib folder. > This helps with users not getting confused when the CordovaLib.xcodeproj is a > subproject in their project (since it lists all targets of the subproject) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org