[
https://issues.apache.org/jira/browse/CB-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522555#comment-15522555
]
ASF GitHub Bot commented on CB-11028:
-------------------------------------
GitHub user matrosovN opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/136
CB-11028 android: Allow to set custom labels for contacts' fields
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
It was not possible before to retrieve the value of custom field's label
(e.g. 'My phone'). The returned contact was always containing for such fields.
This updates Android implementation to return custom label's value rather than
custom similar to iOS.
### What testing has been done on this change?
Auto test
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosovN/cordova-plugin-contacts CB-11028
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
----
commit 200f1fdd9d69bdad2c3d4c315f6c4bc40159ae6e
Author: Nikita Matrosov <matrosov.nikit...@gmail.com>
Date: 2016-09-26T09:22:13Z
CB-11028 android: Allow to set custom labels for contacts' fields
It was not possible before to retrieve the value of custom field's label
(e.g. 'My phone'). The returned contact was always containing for such fields.
This updates Android implementation to return custom label's value rather than
custom similar to iOS.
----
> Android version of the contacts plugin behaves differently for Contact Detail
> "type"
> ------------------------------------------------------------------------------------
>
> Key: CB-11028
> URL: https://issues.apache.org/jira/browse/CB-11028
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Reporter: Tobias Mücksch
> Labels: Android, triaged
>
> After inspecting the code for the android version of the plugin, I found out,
> that for some reason the coders decided to return { ..., type: "custom", ...
> } for contact details with custom labels. But the iOS Version returns the
> actual custom label as type.
> Example:
> *iOS:*
> {code:javascript}
> {
> name: [ ... ],
> phoneNumbers: [{
> id: 1337,
> type: "My super fancy label",
> value: "+41 45654 214654"
> }]
> }
> {code}
> *Android:*
> {code:javascript}
> {
> name: [ ... ],
> phoneNumbers: [{
> id: 1337,
> type: "custom", // WHAT THE HECK?
> value: "+41 45654 214654"
> }]
> }
> {code}
> This behaviour is not exclusive to phoneNumbers. It's the same for all
> ContactDetails.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
