[
https://issues.apache.org/jira/browse/CB-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15544571#comment-15544571
]
ASF GitHub Bot commented on CB-11926:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/17#discussion_r81695543
--- Diff: lib/PluginsManager.js ---
@@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins
= function () {
installedPlugins.forEach(function(plugin) {
// there is test plugin available
if (fs.existsSync(path.join(plugin.dir, 'tests', 'plugin.xml'))) {
- me.installSinglePlugin(path.join(plugin.dir, 'tests'));
+ var additionalArgs = '';
+ if (plugin.id.indexOf('cordova-plugin-file-transfer') >= 0) {
+ var fileServerUrl =
Server.prototype.getConnectionAddress.bind({
+ externalServerUrl: me.config.getExternalServerUrl()
+ }, me.config.getPlatformId())() + ':5000';
+ additionalArgs += ' --variable
FILETRANSFER_SERVER_ADDRESS=' + fileServerUrl;
+ }
+ me.installSinglePlugin(path.join(plugin.dir, 'tests') +
additionalArgs);
}
});
// this will list installed plugins and their versions
this.showPluginsVersions();
};
PluginsManager.prototype.installSinglePlugin = function (plugin) {
- if (fs.existsSync(path.resolve(this.storedCWD, plugin))) {
- plugin = path.resolve(this.storedCWD, plugin);
+ var pluginPath = plugin;
+ var args = '';
+ // separate plugin name from args
+ var argsIndex = plugin.indexOf(' --');
--- End diff --
So you're building a string in `installTestsForExistingPlugins` and then
splitting it back to `(plugin, arguments)` tuple? I don't think this is an
efficient way to pass additional arguments to the function. Can we just add an
optional argument to be able to specify any flags to `cordova plugin add`?
> File-transfer tests should be able to use local file server
> -----------------------------------------------------------
>
> Key: CB-11926
> URL: https://issues.apache.org/jira/browse/CB-11926
> Project: Apache Cordova
> Issue Type: Test
> Components: Paramedic, Plugin File Transfer
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
> Priority: Minor
> Labels: triaged
>
> File-transfer tests should be able to use locally running file server instead
> of relying only on Apache infrastructure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
