[ 
https://issues.apache.org/jira/browse/CB-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566125#comment-15566125
 ] 

ASF GitHub Bot commented on CB-11997:
-------------------------------------

GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23

    CB-11997: Add crash recovery for iOS 8

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Reloads the WebView when it crashes. This behavior already exists on iOS >= 
9, but has not been added for iOS 8.
    
    ### What testing has been done on this change?
    I've tried consuming a bunch of memory in javascript to cause a crash. The 
app reloads successfully.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-plugin-wkwebview-engine 
master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit d9d30f2cf91f307b44ecc5efe1763ae7d0b3bdb3
Author: Connor Pearson <cjp...@gmail.com>
Date:   2016-10-11T18:04:37Z

    CB-11997: Add crash recovery for iOS 8

----


> The webView should reload when a crash occurs (iOS 8)
> -----------------------------------------------------
>
>                 Key: CB-11997
>                 URL: https://issues.apache.org/jira/browse/CB-11997
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin WKWebViewEngine
>            Reporter: Connor Pearson
>            Assignee: Shazron Abdullah
>
> When the WKProcess dies, the content is blanked out and the URL becomes nil. 
> This results in a "white screen" that can only be resolved by restarting the 
> app. See this for more info: https://bugs.webkit.org/show_bug.cgi?id=148685
> With the iOS9 API, it is now possible to detect when the WKProcess dies. On 
> iOS 8, we can listen for changes on URL of the WKWebView to be notified when 
> it crashes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to