[
https://issues.apache.org/jira/browse/CB-11951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568434#comment-15568434
]
ASF GitHub Bot commented on CB-11951:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/501
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/501?src=pr) is 80.40%
(diff: 100%)
> Merging [#501](https://codecov.io/gh/apache/cordova-lib/pull/501?src=pr)
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr)
will not change coverage
```diff
@@ master #501 diff @@
==========================================
Files 67 67
Lines 5189 5189
Methods 836 836
Messages 0 0
Branches 1005 1005
==========================================
Hits 4172 4172
Misses 1017 1017
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update
[c44db3d...51e171a](https://codecov.io/gh/apache/cordova-lib/compare/c44db3d7a00779d5c7eb5ae6150847156858a4f7...51e171a4a3802fe693de4603a08a3584e302e19c?src=pr)
> Plugin preference default value is not being saved to <platform>.json
> ---------------------------------------------------------------------
>
> Key: CB-11951
> URL: https://issues.apache.org/jira/browse/CB-11951
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, CordovaLib
> Affects Versions: 6.3.1
> Environment: Windows 10 with anniversary update
> Reporter: Alexander Sorokin
> Assignee: Nikita Matrosov
>
> Plugin preference default value is not being saved to <platform>.json
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android
> cordova plugin add cordova-plugin-ms-azure-mobile-engagement --variable
> AZME_ANDROID_CONNECTION_STRING=Endpoint=0;AppId=0;SdkKey=0 --variable
> AZME_ENABLE_PLUGIN_LOG=false
> {noformat}
> check out `./platforms/android/android.json` or `./pluguns/android.json`
> it has the following lines:
> {code}
> "installed_plugins": {
> <...>
> "cordova-plugin-ms-azure-mobile-engagement": {
> "AZME_ENABLE_PLUGIN_LOG": "false",
> "AZME_ANDROID_GOOGLE_PROJECT_NUMBER": "null",
> "AZME_ANDROID_REACH_ICON": "icon",
> "AZME_ANDROID_CONNECTION_STRING": "Endpoint=0;AppId=0;SdkKey=0",
> "PACKAGE_NAME": "io.cordova.hellocordova"
> }
> },
> {code}
> You can see that "AZME_ENABLE_PLUGIN_LOG" is saved here, while
> "AZME_ENABLE_NATIVE_LOG" is not.
> They both can be found in the plugin section of the plugin's `plugin.xml`
> file:
> https://github.com/Azure/azure-mobile-engagement-cordova/blob/master/plugin.xml#L29
> Note that the Android-specific preferences have been saved correctly.
> cordova@6.3.0 doesn't have this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
