[
https://issues.apache.org/jira/browse/CB-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588252#comment-15588252
]
ASF GitHub Bot commented on CB-10973:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/193
CB-10973 inAppBrowser for Windows Platform: wrong height of webview w…
…ith location=yes
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Redoing as there was still a little gap
### What testing has been done on this change?
Tested on Windows Phone 8.1 Lumia 640, 525,
Windows 10 Mobile 525, 1520,
Windows 10 desktop
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10973
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
----
commit 19182dace270697a5c41416c654159bb0c542b35
Author: daserge <v-ses...@microsoft.com>
Date: 2016-10-19T09:52:11Z
CB-10973 inAppBrowser for Windows Platform: wrong height of webview with
location=yes
Redoing as there was still a little gap
----
> inAppBrowser for Windows Platform: wrong height of webview with location=yes
> ----------------------------------------------------------------------------
>
> Key: CB-10973
> URL: https://issues.apache.org/jira/browse/CB-10973
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
> Affects Versions: 6.0.0
> Environment: Windows Phone 10, cordova-windows@4.3.1,
> cordova-plugin-inappbrowser@1.2.1
> Reporter: Roberto De Simone
> Assignee: Sergey Shakhnazarov
> Labels: Windows, triaged
> Attachments: inAppBrowser-wrong-height.png
>
>
> When setting location=yes, the height of the webview is by some pixels too
> small. Please see attached screenshot with the green remarks.
> ref = cordova.InAppBrowser.open(h, '_blank', 'location=yes fullscreen=yes');
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
