[ https://issues.apache.org/jira/browse/CB-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588860#comment-15588860 ]
ASF GitHub Bot commented on CB-11933: ------------------------------------- Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/203#discussion_r84077075 --- Diff: spec/unit/ConfigChanges.spec.js --- @@ -57,76 +57,98 @@ describe('PlatformMunger', function () { it('should call parent\'s method with the same parameters', function () { munger.apply_file_munge(WINDOWS_MANIFEST, munge, false); - expect(BaseMunger.prototype.apply_file_munge).toHaveBeenCalledWith(WINDOWS_MANIFEST, munge, false); --- End diff -- Why do we need to remove these checks? > [windows] uap: not added on plugin add > -------------------------------------- > > Key: CB-11933 > URL: https://issues.apache.org/jira/browse/CB-11933 > Project: Apache Cordova > Issue Type: Bug > Components: Windows > Reporter: Sergey Shakhnazarov > Assignee: Nikita Matrosov > > {noformat} > cordova create test > cd test > cordova platform add https://github.com/apache/cordova-windows > cordova plugin add > https://github.com/AzureAD/azure-activedirectory-library-for-cordova > cordova plugin add plugins\cordova-plugin-ms-adal\src\windows\sso\ > type platforms\windows\package.windows10.appxmanifest > {noformat} > -> > {noformat} > <Capabilities> > <Capability Name="internetClient" /> > <Capability Name="enterpriseAuthentication" /> > <Capability Name="privateNetworkClientServer" /> > <Capability Name="sharedUserCertificates" /> > </Capabilities> > {noformat} > {{cordova prepare}} > {noformat} > type platforms\windows\package.windows10.appxmanifest > {noformat} > {noformat} > <Capabilities> > <Capability Name="internetClient" /> > <uap:Capability Name="enterpriseAuthentication" /> > <Capability Name="privateNetworkClientServer" /> > <uap:Capability Name="sharedUserCertificates" /> > </Capabilities> > {noformat} > {{cordova plugin rm cordova-plugin-ms-adal-sso}} > {noformat} > type platforms\windows\package.windows10.appxmanifest > {noformat} > {noformat} > <Capabilities> > <Capability Name="internetClient" /> > <uap:Capability Name="enterpriseAuthentication" /> > <uap:Capability Name="sharedUserCertificates" /> > </Capabilities> > {noformat} > 1. uap: prefixes not being added on plugin add > 2. cordova prepare fixes this > 3. plugin rm does not remove added capabilities as they have been changed > cordova-plugin-ms-adal-sso plugin.xml: > {noformat} > <platform name="windows"> > <js-module name="overrides" src="www/overrides.js"> > <runs /> > </js-module> > <config-file target="package.appxmanifest" > parent="/Package/Capabilities" device-target="windows"> > <Capability Name="enterpriseAuthentication" /> > <Capability Name="privateNetworkClientServer" /> > <Capability Name="sharedUserCertificates" /> > </config-file> > </platform> > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org