[
https://issues.apache.org/jira/browse/CB-11206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594633#comment-15594633
]
ASF GitHub Bot commented on CB-11206:
-------------------------------------
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/128
Hey, @proverbface, we did some manual testing of this, and it does seem to
cause problems on devices, other than you mentioned. In particular, on Samsung
Galaxy Note 2 this throws `java.lang.NumberFormatException: Invalid int:
"null"` though the original code is working just fine.
Perhaps it would be better to check if
`cursor.getString(cursor.getColumnIndex(CommonDataKinds.Im.PROTOCOL))` can be
turned into integer first, and if not - fall back to `CUSTOM_PROTOCOL`.
> Contacts plugin causes app crash
> --------------------------------
>
> Key: CB-11206
> URL: https://issues.apache.org/jira/browse/CB-11206
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Reporter: Petr Odut
>
> On Samsung phone app crashes instantly with a stack trace:
> {noformat}
> java.lang.NumberFormatException
> java.lang.Integer.invalidInt(Integer.java:138)
> java.lang.Integer.parseInt(Integer.java:358)
> java.lang.Integer.parseInt(Integer.java:334)
> org.apache.cordova.contacts.ContactAccessorSdk5.imQuery(ContactAccessorSdk5.java:907)
> org.apache.cordova.contacts.ContactAccessorSdk5.populateContactArray(ContactAccessorSdk5.java:435)
> org.apache.cordova.contacts.ContactAccessorSdk5.search(ContactAccessorSdk5.java:282)
> org.apache.cordova.contacts.ContactManager$3.run(ContactManager.java:209)
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
> java.lang.Thread.run(Thread.java:818)
> {noformat}
> JS code to retrieve contacts, on Sony phone the same code works properly:
> {code:javascript}
> if(navigator.contacts) {
> var options = new ContactFindOptions();
> options.multiple = true;
> options.hasPhoneNumber = true;
> navigator.contacts.find([navigator.contacts.fieldType.phoneNumbers],
> contacts => {
> this.phoneContacts = contacts;
> d.resolve(contacts);
> }, e => d.reject(e), options);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
