[
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624749#comment-15624749
]
ASF GitHub Bot commented on CB-12071:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/208
CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova …
…Windows
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Adds a test for missing InProcessServer extension case to prevent further
breakages
### What testing has been done on this change?
Run npm test, checked that None package action breaks the test.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-windows CB-12071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit 369f69a0618658209f29027abb1c114761ce5b83
Author: daserge <[email protected]>
Date: 2016-11-01T08:27:49Z
CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
Adds a test for missing InProcessServer extension case to prevent further
breakages
----
> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> -------------------------------------------------------------------
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugins, Windows
> Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
> Reporter: Luc Humair
> Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's
> package.windows.appxmanifest like:
> {code:xml}
> <Extensions>
> <Extension Category="windows.activatableClass.inProcessServer">
> <InProcessServer>
> <Path>Foo.dll</Path>
> <ActivatableClass ActivatableClassId="Foo.Class"
> ThreadingModel="both" />
> </InProcessServer>
> </Extension>
> </Extensions>
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
> <resource-file device-target="windows"
> src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
> <resource-file device-target="phone"
> src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
> <resource-file src="src/windows/uap/$(Platform)/Foo.dll" target="Foo.dll"
> versions=">=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the
> projects with property "Package Action"="Content" which includes the DLL in
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes the
> DLL's "Package Action" to "None". Now the file is no longer included in the
> package manifest and the build fails for all the platforms with the following
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file
> 'Foo.dll' which is not part of the payload.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
