[ 
https://issues.apache.org/jira/browse/CB-12088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625123#comment-15625123
 ] 

ASF GitHub Bot commented on CB-12088:
-------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/506

    CB-12088 Fix misleading warning when adding platform without Api.js

    ### Platforms affected
    All
    
    ### What does this PR do?
    Changes the logic that emits warning when require `Api.js` for platform 
fails to skip the warning when platform does not expose its Api
    
    ### What testing has been done on this change?
    Manual testing
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimir-kotikov/cordova-lib CB-12088

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #506
    
----
commit ac34793ef188e5eccb99b0227902cadaddee01e6
Author: Vladimir Kotikov <v-vlk...@microsoft.com>
Date:   2016-11-01T10:48:51Z

    CB-12088 Fix misleading warning when adding platform without Api.js

----


> cordova prepare -d failed.
> --------------------------
>
>                 Key: CB-12088
>                 URL: https://issues.apache.org/jira/browse/CB-12088
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 5.0.1
>         Environment: CentOS 6.5 with nodejs 6.9.1
> [root@host-80-0-0-24 acrop-client.git]# cordova --version
> 6.4.0
>            Reporter: Yonggang Luo
>
> [root@host-80-0-0-24 acrop-client.git]# cordova prepare --verbose
> No scripts found for hook "before_prepare".
> Checking config.xml for saved platforms that haven't been added to the project
> Error loading cordova-browser
> Checking for any plugins added to the project that have not been installed in 
> browser platform
> No differences found between plugins added to project and installed in 
> browser platform. Continuing...
> Generating config.xml from defaults for platform "browser"
> No scripts found for hook "after_prepare".
> Checking config.xml for saved plugins that haven't been added to the project



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to