[
https://issues.apache.org/jira/browse/CB-12098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655440#comment-15655440
]
ASF GitHub Bot commented on CB-12098:
-------------------------------------
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/273#discussion_r87504333
--- Diff:
bin/templates/project/__PROJECT_NAME__/Classes/MainViewController.m ---
@@ -92,7 +92,13 @@ - (UIWebView*) newCordovaViewWithFrame:(CGRect)bounds
return[super newCordovaViewWithFrame:bounds];
}
-- (NSUInteger)supportedInterfaceOrientations
+// CB-12098
+#if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000
+- (NSUInteger)supportedInterfaceOrientations
+#else
+- (UIInterfaceOrientationMask)supportedInterfaceOrientations
+#endif
+
--- End diff --
remove this empty line
> Update supportedInterfaceOrientations return type
> -------------------------------------------------
>
> Key: CB-12098
> URL: https://issues.apache.org/jira/browse/CB-12098
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 3.5.0
> Reporter: Jesse MacFadyen
> Assignee: sterling gerritz
> Priority: Minor
>
> All of our uses of supportedInterfaceOrientations should return
> UIInterfaceOrientationMask in iOS 9+
> {code}
> #if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000
> - (NSUInteger)supportedInterfaceOrientations
> #else
> - (UIInterfaceOrientationMask)supportedInterfaceOrientations
> #endif
> {code}
> The full list of references is here:
> https://github.com/apache/cordova-ios/search?utf8=%E2%9C%93&q=supportedInterfaceOrientations
> A similar fix was just implemented for [CB-11189]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
