[ 
https://issues.apache.org/jira/browse/CB-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662456#comment-15662456
 ] 

ASF GitHub Bot commented on CB-12132:
-------------------------------------

Github user cordova-qa commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/197
  
    Cordova CI Build has one or more failures. 
    
    **Commit**     - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/197/commits/52d12445685f333a9c386287bab0d12b937c85bd)
    **Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95/)
    
    | Builder Name  | Console Output | Test Report | Device Logs  |
    |     :---:     |     :---:      |   :---:     |     :---:    |
    | [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-8.1-store/artifact/)
 |
    | [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-10-store/artifact/)
 |
    | [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=windows-8.1-phone/artifact/)
 |
    | [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=ios/artifact/)
 |
    | [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/95//PLATFORM=android/artifact/)
 |
     



> Add hidenotcloseoption
> ----------------------
>
>                 Key: CB-12132
>                 URL: https://issues.apache.org/jira/browse/CB-12132
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin InAppBrowser
>            Reporter: Gaven Henry
>            Priority: Minor
>              Labels: features
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> add a new option for android and ios:
> option: hidenotclose=yes
> this makes the done button on iOS or the X button android hide the 
> inappbrowser webview instead of closing and destroying it.
> this is useful when doing something like:
> load a webview hidden (so it's nice and preloaded for the user)
> use the show() method when the user clicks to see it
> use the done/X button to hide the window
> call the close() method when done to clean up
> this allows us to start pre-loading the data, open and close the window 
> multiple times without having to reload and then to call close when done to 
> dispose of the view and clean up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to