[ https://issues.apache.org/jira/browse/CB-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701390#comment-15701390 ]
ASF GitHub Bot commented on CB-9287: ------------------------------------ Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89726251 --- Diff: cordova-js-src/confighelper.js --- @@ -22,16 +22,17 @@ // config.xml wrapper (non-node ConfigParser analogue) var config; function Config(xhr) { - function loadPreferences(xhr) { + function load(xhr, tagName) { var parser = new DOMParser(); var doc = parser.parseFromString(xhr.responseText, "application/xml"); - var preferences = doc.getElementsByTagName("preference"); + var preferences = doc.getElementsByTagName(tagName); return Array.prototype.slice.call(preferences); } this.xhr = xhr; - this.preferences = loadPreferences(this.xhr); + this.preferences = load(this.xhr, "preference"); + this.splashScreens = load(this.xhr, "splash"); --- End diff -- Calling `load` second time here will trigger re-parsing of `config.xml` which, I believe, is not very efficient. Might be better to rework `load` method to reuse already parsed document > Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1 > ------------------------------------------------------------------------ > > Key: CB-9287 > URL: https://issues.apache.org/jira/browse/CB-9287 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen, Windows > Affects Versions: 4.0.0 > Environment: Cordova 4.0.0, Windows Platform 3.7.1 > Reporter: Dennis Patzer > Assignee: Jesse MacFadyen > Labels: triaged, windows > Attachments: splashscreens_windows_universal_app.jpg > > Original Estimate: 24h > Remaining Estimate: 24h > > For some reason, for example only one splashscreen size is supported > (620x300). When I add other sizes by adding the following line: > <splash > src="../resources/themes/windows-phone/img/splashscreen/splashscreen.scale-140.png" > width="868" height="420" /> > The image isn't copied to the cordova/platforms/windows/images folder when > building. This is the reason why it's also not included and referenced in the > resulting package.windows.appxmanifest. > Why is that?? Or am I doing something wrong? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org