[
https://issues.apache.org/jira/browse/CB-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815273#comment-15815273
]
ASF GitHub Bot commented on CB-12336:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/171
CB-12336 (android) Do not call win callback if aborted
### Platforms affected
Android
### What does this PR do?
Fixes a rare condition on Android when win callback is called even after
the `abort()`.
Added a test to make sure the `aborted` flag is reset correctly at the next
download attempt.
### What testing has been done on this change?
~10 test runs on CI
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-file-transfer
CB-12336
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #171
----
commit 9093e68de8f27b70af8418b351d6592d8b8abc01
Author: Alexander Sorokin <alexander.soro...@akvelon.com>
Date: 2017-01-09T16:12:15Z
CB-12336 (android) Do not call win callback if aborted
----
> filetransfer.spec.9 is flaky on Android
> ---------------------------------------
>
> Key: CB-12336
> URL: https://issues.apache.org/jira/browse/CB-12336
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Affects Versions: Master
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
> Labels: flaky, found-by-ci, triaged
>
> filetransfer.spec.9 sometimes fails on Android:
> http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/269/PLATFORM=android-4.4,PLUGIN=cordova-plugin-file-transfer/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
