[ https://issues.apache.org/jira/browse/CB-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828206#comment-15828206 ]
ASF GitHub Bot commented on CB-12364: ------------------------------------- GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/207 CB-12364 [Windows] Inappbrowser inject file manual tests are not working <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Windows ### What does this PR do? - Updates ms-appx-web to ms-appx in inject style/script methods as ms-appx-web is not supported by getFileFromApplicationUriAsync - Forces to use cordova-plugin-dialogs on Windows as window.alert is non functional ### What testing has been done on this change? Manual and auto tests ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-12364 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/207.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #207 ---- commit e54a6d6657ea88feaa4899402776ac3d5e49d118 Author: daserge <v-ses...@microsoft.com> Date: 2017-01-18T14:42:55Z CB-12364 [Windows] Inappbrowser inject file manual tests are not working ---- > [Windows] Inappbrowser inject file manual tests are not working > --------------------------------------------------------------- > > Key: CB-12364 > URL: https://issues.apache.org/jira/browse/CB-12364 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser > Environment: UWP > Reporter: Sergey Shakhnazarov > Assignee: Sergey Shakhnazarov > Labels: triaged, windows > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org