[
https://issues.apache.org/jira/browse/CB-12415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849639#comment-15849639
]
ASF GitHub Bot commented on CB-12415:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/225
CB-12415 Windows build fails if start page is missing
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Continue the build if the start page is missing on disk.
### What testing has been done on this change?
Run npm test, manual test
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-windows CB-12415
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #225
----
commit d20d594511f9e2d85cbb01f0df63ccba8d9a0a24
Author: daserge <v-ses...@microsoft.com>
Date: 2017-02-02T08:19:56Z
CB-12415 Windows build fails if start page is missing
----
> Windows build fails if start page is missing
> --------------------------------------------
>
> Key: CB-12415
> URL: https://issues.apache.org/jira/browse/CB-12415
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: Master, 4.4.3
> Reporter: Alexander Sorokin
> Priority: Minor
> Labels: triaged
>
> Repro:
> {noformat}
> cordova create foo
> rm ./foo/www/index.html
> cd foo
> cordova platform add windows@https://github.com/apache/cordova-windows
> cordova build
> {noformat}
> Expected:
> Build successful
> Actual:
> {noformat}
> Building project: C:\Cordova\foo\platforms\windows\CordovaApp.Windows.jsproj
> Configuration : debug
> Platform : anycpu
> Patching 8.1 in prebuild event...
> ls: no such file or directory:
> C:\Cordova\foo\platforms\windows\www\index.html
> grep: no paths given
> C:\Cordova\foo\platforms\windows\cordova\prebuild.js:65
> if (shell.grep(reBaseJs, startPageFilePath).length === 0) {
> ^
> TypeError: Cannot read property 'length' of null
> at patch (C:\Cordova\foo\platforms\windows\cordova\prebuild.js:65:48)
> at Object.<anonymous>
> (C:\Cordova\foo\platforms\windows\cordova\prebuild-81.js:20:1)
> at Module._compile (module.js:409:26)
> at Object.Module._extensions..js (module.js:416:10)
> at Module.load (module.js:343:32)
> at Function.Module._load (module.js:300:12)
> at Function.Module.runMain (module.js:441:10)
> at startup (node.js:139:18)
> at node.js:974:3
> C:\Program Files
> (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(1250,5): error
> MSB3073: The command "node "C:\Cor
> dova\foo\platforms\windows\\\cordova\\prebuild-81.js"" exited with code 1.
> [C:\Cordova\foo\platforms\windows\CordovaApp.Windows.j
> sproj]
> Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed
> with exit code 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
