[ 
https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871926#comment-15871926
 ] 

ASF GitHub Bot commented on CB-12468:
-------------------------------------

Github user cordova-qa commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/213
  
    Cordova CI Build has completed successfully.
    
    **Commit**     - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/213/commits/b2ca311b587af5d2168873f49a86d6cc67b67789)
    **Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125/)
    
    | Builder Name  | Console Output | Test Report | Device Logs  |
    |     :---:     |     :---:      |   :---:     |     :---:    |
    | [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=windows-10-store/artifact/)
 |
    | [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-9.3/artifact/)
 |
    | [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-10.0/artifact/)
 |
    | [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-4.4/artifact/)
 |
    | [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-5.1/artifact/)
 |
     



> cordova-inappbrowser-plugin setDefaultOptions method
> ----------------------------------------------------
>
>                 Key: CB-12468
>                 URL: https://issues.apache.org/jira/browse/CB-12468
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: AllPlatforms, CordovaLib
>    Affects Versions: 3.5.0
>         Environment: IOS/Android
>            Reporter: Ivan Prodaiko
>              Labels: features
>             Fix For: Master
>
>
> While using cordova-inappbrowser-plugin I must set popup features only when 
> calling window.open method. But a lot of libraries (firebase, openFB) use 
> window.open inside their own code where I can't directly menage the features 
> of window to be opened, and on IOS, where we do not a have a 'back' button we 
> could have a problem. For example window, opened with 'toolbar=no' will make 
> app to stack with no ability to close the window. Another thing to be 
> mentioned is when on IOS you use <video inline> attribute, after opening a 
> new window without setting 'allowInlineMediaPlayback=yes' all inline 
> attributes will stop working properly and video will start to open in a 
> fullscreen mode.
> So, my proposal is to provide an ability to setDefaultOptions method that 
> will help to prevent external libraries to manage the options of of window to 
> be opened directly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to