[
https://issues.apache.org/jira/browse/CB-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886175#comment-15886175
]
ASF GitHub Bot commented on CB-12424:
-------------------------------------
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/358
@kalliste Thanks for submitting the ICLA. Is it possible for you to add a
Unit Test to the new Unit Testing framework for this patch? People have been
complaining about this being a regression despite the fact that we have zero
documentation and zero tests. (In fact the refactored bridge had absolutely no
unit tests until now, which is why I haven't pulled this in yet and have been
working on getting some tests up.) The test project is in tests, and it's a
standard Android project using JUnit and Espresso.
> Multipart messages are broken
> -----------------------------
>
> Key: CB-12424
> URL: https://issues.apache.org/jira/browse/CB-12424
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 6.0.0, 6.2.0
> Environment: cordova 6.4.0
> android 6.0.0 / git master
> Mac El Capitan
> Reporter: Joshua Jackson
> Priority: Minor
> Fix For: 6.2.0
>
>
> Currently when I try to assemble a multipart message cordova-android
> assembles the data in NativeToJsMessageQueue.java as [""] but if I call
> pMessageLoopResponse(callbackContext, 3, 5) it should generate [3, 5]
> private void pMessageLoopResponse(final CallbackContext ctx, int iMsg,
> int iTag) {
> List<PluginResult> results = new ArrayList<PluginResult>();
> results.add(0, new PluginResult(PluginResult.Status.OK, iMsg));
> results.add(1, new PluginResult(PluginResult.Status.OK, iTag));
> PluginResult result = new PluginResult(PluginResult.Status.OK,
> results);
> result.setKeepCallback(true);
> ctx.sendPluginResult(result);
> }
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
