[ 
https://issues.apache.org/jira/browse/CB-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887083#comment-15887083
 ] 

ASF GitHub Bot commented on CB-12016:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/522#discussion_r103362278
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -342,13 +322,6 @@ function copyPlugin(pinfo, plugins_dir, link) {
         var dest = path.join(plugins_dir, pinfo.id);
         var altDest;
     
    -    //check if alternative id already exists in plugins directory
    -    if(pluginMapperotn[pinfo.id]) {
    -        altDest = path.join(plugins_dir, pluginMapperotn[pinfo.id]);
    -    } else if(pluginMappernto[pinfo.id]) {
    -        altDest = path.join(plugins_dir, pluginMappernto[pinfo.id]);
    -    }
    -
         if(fs.existsSync(altDest)) {
    --- End diff --
    
    I think altDest doesn't need to exist anymore


> remove plugin ID mapping
> ------------------------
>
>                 Key: CB-12016
>                 URL: https://issues.apache.org/jira/browse/CB-12016
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI, CordovaLib
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> For cordova@7, we can remove the cordova-registry-mapper module and remove 
> the automatic plugin mapping we do



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to