[
https://issues.apache.org/jira/browse/CB-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903746#comment-15903746
]
ASF GitHub Bot commented on CB-12524:
-------------------------------------
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/367#discussion_r105255990
--- Diff: bin/lib/check_reqs.js ---
@@ -78,21 +79,46 @@ module.exports.check_ant = function() {
});
};
+module.exports.get_gradle_wrapper = function() {
+ var androidStudioPath;
+ if(os.platform() == "darwin") {
--- End diff --
@dpogue Honestly, we're just installing the wrapper, so any will work. I
wanted to delete
https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L187
for a while, since it replaces everything with an old version of Gradle that
just gets updated anyway, but we might just have to keep it in and update it to
the latest Gradle supported.
FYI: My homebrew keeps fetching 2.2, and Android Studio 2.3 is packaged
with 3.2 on my Windows and Mac partitions.
> add plugin failing because it cannot find tools/templates
> ---------------------------------------------------------
>
> Key: CB-12524
> URL: https://issues.apache.org/jira/browse/CB-12524
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, App Hello World
> Affects Versions: 6.5.0
> Environment: Mac OSX 10.12.3
> Cordova 6.5.0
> Android 6.1.2
> Reporter: Gary N Griswold
> Assignee: Joe Bowser
> Priority: Blocker
>
> plugin add is failing because it is looking for in
> sdk/tools/templates/gradle/wrapper, but tools/templates does not exist.
> The reference to the missing templates directory is found in
> {quote}check_reqs.js line 88{quote}
> {code}
> platforms/android/cordova/lib/check_reqs.js
> line 88: var wrapperDir = path.join(sdkDir, 'tools', 'templates', 'gradle',
> 'wrapper');
> Please see the
> cordova plugin add $HOME/<local file spec>
> Failed to install 'com-shortsands-videoplayer':CordovaError: Could not find
> gradle wrapper within Android SDK. Might need to update your Android SDK.
> Looked here:
> /Users/garygriswold/Library/Android/sdk/tools/templates/gradle/wrapper
> at Object.module.exports.check_gradle
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/check_reqs.js:90:25)
> at GradleBuilder.prepEnv
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/builders/GradleBuilder.js:161:23)
> at Api.module.exports.runClean
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/build.js:131:20)
> at
> /Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/Api.js:394:50
> at _fulfilled
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:834:54)
> at self.promiseDispatch.done
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:863:30)
> at Promise.promise.promiseDispatch
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:796:13)
> at
> /Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:604:44
> at runSingle
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:137:13)
> at flush
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:125:13)
> Error: Could not find gradle wrapper within Android SDK. Might need to update
> your Android SDK.
> Looked here:
> /Users/garygriswold/Library/Android/sdk/tools/templates/gradle/wrapper
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
