[
https://issues.apache.org/jira/browse/CB-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966976#comment-15966976
]
ASF GitHub Bot commented on CB-11895:
-------------------------------------
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/302#discussion_r111295873
--- Diff:
CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
---
@@ -115,11 +115,18 @@ +
(BOOL)shouldOverrideLoadWithRequest:(NSURLRequest*)request navigationType:(UIW
case CDVIntentAndNavigationFilterValueNavigationAllowed:
return YES;
case CDVIntentAndNavigationFilterValueIntentAllowed:
- // only allow-intent if it's a
UIWebViewNavigationTypeLinkClicked (anchor tag) OR
- // it's a UIWebViewNavigationTypeOther, and it's an internal
link
- if ([[self class] shouldOpenURLRequest:request
navigationType:navigationType]){
--- End diff --
Whoops; trigger-happy `dd`, apparently. Fixing up.
> openURL deprecated in iOS 10 (new selector replaces it)
> -------------------------------------------------------
>
> Key: CB-11895
> URL: https://issues.apache.org/jira/browse/CB-11895
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Kerri Shotts
> Labels: easyfix
> Fix For: cordova-ios@4.4.0
>
>
> Article:
> http://useyourloaf.com/blog/openurl-deprecated-in-ios10
> Our usage:
> https://github.com/apache/cordova-ios/blob/3bda0ef487f204e60def4ff1ecf844862460313e/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L121
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
