[
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973533#comment-15973533
]
ASF GitHub Bot commented on CB-8978:
------------------------------------
Github user shazron commented on the issue:
https://github.com/apache/cordova-android/pull/321
Leaving some notes here for future reference (in case there are bugs):
1. Firstly `cleanFileResources` is called, but effectively useless during
runtime, even if you have a `<resource-file>` tag in config.xml since prepare
does not send a project config (see my line comments above and
https://github.com/apache/cordova-android/blob/dbce4de5b6313b8f10db64166612a8bcb56d898b/bin/templates/cordova/lib/prepare.js#L59)
2. Because of item 1 above, this part of the feature cannot be tested
3. No platform unit tests for this feature, which is important because of
item 2 above (no effective test available)
4. The corresponding iOS implementation of this feature
(https://issues.apache.org/jira/browse/CB-8980 and
https://github.com/apache/cordova-ios/pull/305) has an example of unit tests
> Adding <resource-file> tag support to config.xml
> ------------------------------------------------
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
> Issue Type: New Feature
> Components: CLI, CordovaLib
> Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
> Reporter: Karen Tran
> Assignee: Karen Tran
> Labels: config.xml, images
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that
> handles copying images from a source to destination in the config.xml. These
> elements also only handle copying 1 image only and replacing what was
> previously there as the icon.png or splash.png.
> I'm creating a new tag that will copy non-main app icon images, which could
> be notification icons, button icons, custom image text, etc. and not limited
> to just 1 image.
> Example:
> <image src="res/android/notification.png" name="notification.png" />
> <image src="res/android/notification-mdpi.png" name="notification.png"
> density="mdpi" />
> The required attributes will be src and name.
> Depending on the directory that the image gets copied to, the width and
> height attribute may not be needed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
