[
https://issues.apache.org/jira/browse/CB-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036804#comment-16036804
]
ASF GitHub Bot commented on CB-12882:
-------------------------------------
GitHub user stalniy opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79
CB-12882: (ios): adds support for permissions checks for camera capturing
### Platforms affected
iOS
### What does this PR do?
adds support for checking camera permission and if camera was prohibited
shows alert message with information and 2 buttons: OK and Settings. The same
`cordova-plugin-camera` does
### What testing has been done on this change?
I ran all automated tests, they passed. Also did manual testing and added 2
additional cases in manual tests for checking presence of alert when camera
access was prohibited
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stalniy/cordova-plugin-media-capture
fix/permissions-request
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit 13a5135e1defee4afd0fd38cd3c34d1dcec87580
Author: Sergii Stotskyi <sergii.stots...@concreteplatform.com>
Date: 2017-06-05T10:02:29Z
CB-12882: (ios): adds support for permissions checks for captureVideo and
captureImage methods
----
> captureVideo doesn't close camera picker and doesn't show alert message about
> prohibited camera usage
> -----------------------------------------------------------------------------------------------------
>
> Key: CB-12882
> URL: https://issues.apache.org/jira/browse/CB-12882
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
> Affects Versions: 1.4.2
> Reporter: Sergii Stotskyi
> Labels: ios
>
> *Steps to reproduce*:
> # Create a simple application which calls `captureVideo()` method
> # Deploy application to real device
> # Click on button which starts video capturing
> # Click "No" when it asks permissions for camera
> *Expected result*:
> camera picker is animated out. And every time when user clicks on capture
> video alert is shown as in `cordova-plugin-camera`: Access to the camera has
> been prohibited, please enable it in the Settings app to continue. And 2
> buttons are shown: OK, Settings
> *Actual result*:
> camera picker is not hidden. It's possible to click on record button and
> record black screen. Eventually video is saved and viewed
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
