[ 
https://issues.apache.org/jira/browse/CB-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057264#comment-16057264
 ] 

ASF GitHub Bot commented on CB-12941:
-------------------------------------

GitHub user timbru31 opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/223

    CB-12941: update typings

    ### Platforms affected
    n/a - development via TypeScript
    
    ### What does this PR do?
    Updates the typings to match the latest published version on 
DefinitelyTyped.  
    See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192 and 
https://stackoverflow.com/q/42095516/1902598
    
    ### What testing has been done on this change?
    Project compiles again ;)
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - n/a: Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/timbru31/cordova-plugin-inappbrowser 
feature/update-typings

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #223
    
----
commit 6b36f485f4853f8d448d7de4fed9571d1a45241f
Author: Tim Brust <tim.br...@sinnerschrader.com>
Date:   2017-06-21T09:52:19Z

    CB-12941: update typings

----


> Update typings to latest DefinitelyTyped revision
> -------------------------------------------------
>
>                 Key: CB-12941
>                 URL: https://issues.apache.org/jira/browse/CB-12941
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-inappbrowser
>            Reporter: Tim Brust
>              Labels: inappbrowser, plugins, typescript, typings
>
> Update the typings in the cordova-plugin-inappbrowser to match the current 
> revision published via DefinitelyTyped.
> This fixes e.g. this issue: https://stackoverflow.com/q/42095516/1902598
> DefinitelyTyped PR: 
> https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to