[ https://issues.apache.org/jira/browse/CB-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059050#comment-16059050 ]
ASF GitHub Bot commented on CB-7684: ------------------------------------ GitHub user adriano-di-giovanni opened a pull request: https://github.com/apache/cordova-plugin-media/pull/143 CB-7684 ### Platforms affected iOS ### What does this PR do? This PR will add an `isPlayingOrRecording` method that's called before any try to deactivate the AVSession. ### What testing has been done on this change? This has been tested on 11 apps that are going to updated live. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adriano-di-giovanni/cordova-plugin-media CB-7684_cordova-plugin-media Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #143 ---- commit 0799d12a2c16d341f2e615fb0ca6b4dd1ab1bb1b Author: Adriano Di Giovanni <m...@adrianodigiovanni.com> Date: 2017-06-21T10:45:01Z do not deactivate avsession when items finish playing commit d17c6a2dde8e8bb0e6c53d91283fce9dd8002306 Author: Adriano Di Giovanni <m...@adrianodigiovanni.com> Date: 2017-06-22T09:20:19Z CB76-84: check if any audio file is playing or recording before deactivating the avsession ---- > [Media] CDVSound Kills any and all playing sound files when a single file > finishes > ---------------------------------------------------------------------------------- > > Key: CB-7684 > URL: https://issues.apache.org/jira/browse/CB-7684 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-media > Affects Versions: 3.5.0 > Environment: iOS > Reporter: Nathan Stryker > > The CDVSound file will kill all playing media files when ever a single file > completes playing. The issue is around like 691 in the method > "AudioDidFinishPlaying", with the code: > if (self.avSession) { > [self.avSession setActive:NO error:nil]; > } > The reason I think this is a bug is that if a user as Music file A playing in > a loop and Music file B plays, when B completes the "setActive:NO" will kill > the avSession of both A and B. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org