[
https://issues.apache.org/jira/browse/CB-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083769#comment-16083769
]
ASF GitHub Bot commented on CB-12940:
-------------------------------------
GitHub user igormartsekha opened a pull request:
https://github.com/apache/cordova-ios/pull/326
CB-12940: [IOS] Use deployment-target from config.xml for platform ve…
…rsion in Podfile
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
IOS
### What does this PR do?
It's generate Podfile using `deployment-target` option from config.xml
### What testing has been done on this change?
I runed test but it failed, because API.js need valid path to config.xml
file. So I changed test, and set up valid path.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/igormartsekha/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #326
----
commit 2997480a21f82198232dfa061f9a42c186996ed2
Author: Igor Martsekha <igor.martse...@gmail.com>
Date: 2017-07-12T10:11:57Z
CB-12940: [IOS] Use deployment-target from config.xml for platform version
in Podfile
----
> Use deployment-target for platform version in Podfile
> -----------------------------------------------------
>
> Key: CB-12940
> URL: https://issues.apache.org/jira/browse/CB-12940
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Affects Versions: cordova-ios@4.4.0
> Reporter: Todd Miller
> Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.1
>
>
> The current Podfile.js script is hardcoded to set the platform ios version to
> 8.0. However, there are some pods that require 9.0 or they will fail to
> install. The deployment-target preference should be honored and used when
> generating the Podfile.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
