[ https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092230#comment-16092230 ]
ASF GitHub Bot commented on CB-11244: ------------------------------------- Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/389 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=h1) Report > Merging [#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/893356abcd1b005a13bb09e7467f227b52de3ae5?src=pr&el=desc) will **decrease** coverage by `0.37%`. > The diff coverage is `34.17%`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?height=150&width=650&token=q14nMf6C5a&src=pr)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #389 +/- ## ========================================== - Coverage 42.55% 42.17% -0.38% ========================================== Files 17 17 Lines 1678 1707 +29 Branches 304 310 +6 ========================================== + Hits 714 720 +6 - Misses 964 987 +23 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==) | `30.61% <ø> (-0.38%)` | :arrow_down: | | [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `37.5% <ø> (ø)` | :arrow_up: | | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `13.04% <0%> (-0.39%)` | :arrow_down: | | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `22.44% <0%> (ø)` | :arrow_up: | | [bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz) | `94.73% <100%> (ø)` | :arrow_up: | | [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20% <15.78%> (-0.43%)` | :arrow_down: | | [bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==) | `43.36% <25%> (-1.09%)` | :arrow_down: | | [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `49.26% <45.45%> (-1.57%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=footer). Last update [893356a...d0dab4b](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Update Android Project Structure to be more compatible with Android Studio > -------------------------------------------------------------------------- > > Key: CB-11244 > URL: https://issues.apache.org/jira/browse/CB-11244 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Reporter: Joe Bowser > Assignee: Joe Bowser > Labels: CordovaAndroidSix, android-next > > Currently our existing Android projects have the old Android Project > structure created by default, even for new projects, which makes no sense > since we no longer support Eclipse as the default project editor and have > moved to Android Studio for Android development. > The main reason for doing this is to clean up dependencies and to allow for > projects and dependencies to work more like how modern Android projects work > and to remove as much custom Gradle code as possible. This would also allow > us in the future to move towards having Android Plugin code work as Android > Libraries with Resources instead of just copying things across, which gives > us the ability to add JUnit tests and bundled resources. This would > dramatically increase the quality of plugins such as InAppBrowser, and third > party plugins such as the Barcode Scanner. > This would have to be done on the next major version, and the upgrade would > be tricky to do. However, the benefits at this point would greatly outweigh > the costs of maintaining the old project structure. The old cordova-common > code in Cordova-Android 5.0.x would allow for plugins in the short term to > work with both projects until we get the new project structure ready. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org